Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: fix limit lost in SetOprStmt (#49898) #49932

Merged
merged 8 commits into from
Feb 20, 2024
Merged

parser: fix limit lost in SetOprStmt (#49898) #49932

merged 8 commits into from
Feb 20, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49898

What problem does this PR solve?

Issue Number: close #49874

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 29, 2023
Merged
13 tasks
@Defined2014
Copy link
Contributor

Should wait #49499 merged.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 6, 2024
@Defined2014 Defined2014 force-pushed the cherry-pick-49898-to-release-7.5 branch from 1c53c7e to 16d3e31 Compare February 20, 2024 05:23
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2024
@Defined2014 Defined2014 force-pushed the cherry-pick-49898-to-release-7.5 branch from 16d3e31 to 1c53c7e Compare February 20, 2024 05:24
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2024
@Defined2014 Defined2014 force-pushed the cherry-pick-49898-to-release-7.5 branch from 1c53c7e to c4d9dbf Compare February 20, 2024 08:00
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 08:01:06.435997335 +0000 UTC m=+344155.183620446: ☑️ agreed by Defined2014.
  • 2024-02-20 08:25:36.37757968 +0000 UTC m=+345625.125202791: ☑️ agreed by xhebox.

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@15790a2). Click here to learn what that means.
The diff coverage is 57.4468%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #49932   +/-   ##
================================================
  Coverage               ?   71.9931%           
================================================
  Files                  ?       1404           
  Lines                  ?     407786           
  Branches               ?          0           
================================================
  Hits                   ?     293578           
  Misses                 ?      94487           
  Partials               ?      19721
Flag Coverage Δ
unit 71.9931% <57.4468%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3240% <0.0000%> (?)

@Defined2014
Copy link
Contributor

/retest

@Defined2014
Copy link
Contributor

@yudongusa @easonn7
PTAL

@easonn7
Copy link

easonn7 commented Feb 20, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, easonn7, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit d45020d into pingcap:release-7.5 Feb 20, 2024
17 of 18 checks passed
@Defined2014 Defined2014 deleted the cherry-pick-49898-to-release-7.5 branch February 20, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

@Defined2014 Defined2014

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @Defined2014 @easonn7 @xhebox @tangenta